Conversation
| Q | A | --------------- | ----- | Branch? | 1.7 | Bug fix? | yes | New feature? | no | Related tickets | -
| Q | A | --------------- | ----- | Branch? | 1.7 | Bug fix? | kinda | New feature? | no | Related tickets | -
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SyliusBot
force-pushed
the
upmerge/1.7_2.0
branch
from
6863311 to
27e57c1
Compare
Hello, On the version 1.7.6 for Sylius 1 there is a little error on DI for service `sylius.paypal.client.sftp`, the class is `phpseclib\Net\SFTP` but the `Sylius\PayPalPlugin\Downloader\SftpPayoutsReportDownloader` use `phpseclib3\Net\SFTP` This cause the error on report download : ``` Attempted to load class "SFTP" from namespace "phpseclib\Net". Did you forget a "use" statement for "phpseclib3\Net\SFTP"? ``` Kind regards, Kévin
| Q | A | --------------- | ----- | Branch? | 1.7 | Bug fix? | kinda | New feature? | no | Related tickets | related #414 Should catch these kinds of issues early.
SyliusBot
force-pushed
the
upmerge/1.7_2.0
branch
from
bfee1fe to
b19c782
Compare
| Q | A | --------------- | ----- | Branch? | 1.7 | Bug fix? | no | New feature? | no | Related tickets | -
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been generated automatically.
For more details see upmerge_pr.yaml.
Remember! The upmerge should always be merged with using
Merge pull requestbutton.In case of conflicts, please resolve them manually with usign the following commands:
If you use other name for the upstream remote, please replace
upstreamwith the name of your remote pointing to theSylius/PayPalPluginrepository.Once the conflicts are resolved, please run
git merge --continueand push the changes to this PR.